Update Kotlin to v1.8.0 by 3flex · Pull Request #5614 · detekt/detekt

3flex · 2022-12-08T22:04:07Z

https://kotlinlang.org/docs/whatsnew18.html
https://github.com/JetBrains/kotlin/releases/tag/v1.8.0

codecov · 2022-12-08T22:17:26Z

Codecov Report

Merging #5614 (c56b9ab) into main (110c6f9) will not change coverage.
The diff coverage is n/a.

❗ Current head c56b9ab differs from pull request most recent head a62714b. Consider uploading reports for the commit a62714b to get more accurate results

@@     Coverage Diff      @@
##   main   #5614   +/-   ##
============================
============================

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

3flex · 2022-12-08T22:24:40Z

💥

3flex · 2022-12-10T01:09:00Z

Blocked on tschuchortdev/kotlin-compile-testing#336

We might need to switch to running all tests via CLI and/or Gradle for the compiler plugin to avoid being continuously blocked by this dependency when Kotlin is updated. That dependency isn't updated frequently.

This is the default backend from Kotlin 1.8 but an opt-in is required.

https://kotlinlang.org/docs/whatsnew18.html#exposing-kotlin-compiler-options-as-gradle-lazy-properties

3flex · 2022-12-30T01:45:01Z


+tasks.test {
+    // https://github.com/detekt/detekt/issues/5646
+    enabled = false


* Update Kotlin to v1.8.0 * Add required annotations for Kotlin 1.8 * Set IR backend mode explicitly in JS Gradle tests This is the default backend from Kotlin 1.8 but an opt-in is required. * Migrate from kotlinOptions to compilerOptions https://kotlinlang.org/docs/whatsnew18.html#exposing-kotlin-compiler-options-as-gradle-lazy-properties * Update list of compatible JVM targets * Disable :detekt-compiler-plugin:test task

tokuhirom · 2023-03-03T06:50:43Z

Is there a plan to release new version includes this commit? I want to use detekt with kotlin-1.8.x

3flex · 2023-03-03T07:02:03Z

You can either:

Use a snapshot version of detekt which has this commit included.
Update your project to Kotlin 1.8 but use the existing detekt version. As long as you're not using any new Kotlin 1.8 language features this should work.

eboudrant · 2023-03-07T02:08:04Z

Update your project to Kotlin 1.8 but use the existing detekt version. As long as you're not using any new Kotlin 1.8 language features this should work.

What do you mean by that? We updated to Kotlin 1.8.10 (along with Ksp 1.8.10-1.0.9, Compose Kotlin compiler 1.4.2, Detekt 1.22.0) but we still see the error, we're not using any new Kotlin 1.8 language features.

btw, using snapshots works.

3flex · 2023-03-07T11:53:10Z

we still see the error

What error do you see? Consider opening a new issue so we can assist.

ravermeister · 2023-03-17T14:33:25Z

I have the same problem as described above, after trying to switch to kotlin 1.8 with same detekt version 1.22.0 I see:

* What went wrong:
Execution failed for task ':archiv-impl:detekt'.
> Analyzing /builds/path/to/sourceFolder/src/main/kotlin/de/company/package/info/CacheInfo.kt led to an exception.
  Location: io.gitlab.arturbosch.detekt.rules.bugs.ImplicitDefaultLocale.checkStringFormatting(ImplicitDefaultLocale.kt:70)
  The original exception message was: 'org.jetbrains.kotlin.psi.KtExpression org.jetbrains.kotlin.resolve.calls.util.CallUtilKt.getCalleeExpressionIfAny(org.jetbrains.kotlin.psi.KtElement)'
  Running detekt '1.22.0' on Java '17.0.6+10' on OS 'Linux'
  If the exception message does not help, please feel free to create an issue on our GitHub page.

3flex · 2023-03-17T21:50:00Z

Hi, please open a new issue for this, thanks!

pexa-agopalakrishnan · 2024-04-15T13:03:33Z

I have the same problem as described above, after trying to switch to kotlin 1.8 with same detekt version 1.22.0 I see:

* What went wrong:
Execution failed for task ':archiv-impl:detekt'.
> Analyzing /builds/path/to/sourceFolder/src/main/kotlin/de/company/package/info/CacheInfo.kt led to an exception.
  Location: io.gitlab.arturbosch.detekt.rules.bugs.ImplicitDefaultLocale.checkStringFormatting(ImplicitDefaultLocale.kt:70)
  The original exception message was: 'org.jetbrains.kotlin.psi.KtExpression org.jetbrains.kotlin.resolve.calls.util.CallUtilKt.getCalleeExpressionIfAny(org.jetbrains.kotlin.psi.KtElement)'
  Running detekt '1.22.0' on Java '17.0.6+10' on OS 'Linux'
  If the exception message does not help, please feel free to create an issue on our GitHub page.

yes, im also facing the same issue after upgrading

github-actions Bot added the dependencies Pull requests that update a dependency file label Dec 8, 2022

vercel Bot deployed to Preview December 8, 2022 22:09 View deployment

github-actions Bot added the gradle label Dec 10, 2022

vercel Bot deployed to Preview December 10, 2022 00:36 View deployment

3flex force-pushed the kotlin-1.8 branch from 40d2f84 to 5895a7a Compare December 10, 2022 00:43

vercel Bot deployed to Preview December 10, 2022 00:50 View deployment

vercel Bot deployed to Preview December 10, 2022 01:45 View deployment

3flex added the blocked label Dec 10, 2022

3flex added this to the 1.23.0 milestone Dec 10, 2022

vercel Bot deployed to Preview December 20, 2022 22:18 View deployment

3flex force-pushed the kotlin-1.8 branch from f699e7f to 4892162 Compare December 22, 2022 23:23

vercel Bot deployed to Preview December 22, 2022 23:31 View deployment

schalkms mentioned this pull request Dec 28, 2022

Update kotlin monorepo to v1.8.0 #5642

Closed

1 task

vercel Bot deployed to Preview December 28, 2022 21:49 View deployment

3flex added 4 commits December 30, 2022 09:27

Update Kotlin to v1.8.0

af7264b

Add required annotations for Kotlin 1.8

96adfb2

Set IR backend mode explicitly in JS Gradle tests

5d260fc

This is the default backend from Kotlin 1.8 but an opt-in is required.

Migrate from kotlinOptions to compilerOptions

c63585d

https://kotlinlang.org/docs/whatsnew18.html#exposing-kotlin-compiler-options-as-gradle-lazy-properties

3flex force-pushed the kotlin-1.8 branch from 929ce6f to 3b6497e Compare December 30, 2022 00:46

github-actions Bot added build cli labels Dec 30, 2022

3flex changed the title ~~Smoke test Kotlin 1.8~~ Update Kotlin to v1.8.0 Dec 30, 2022

3flex marked this pull request as ready for review December 30, 2022 00:46

3flex added notable changes Marker for notable changes in the changelog and removed blocked labels Dec 30, 2022

vercel Bot deployed to Preview December 30, 2022 00:50 View deployment

github-advanced-security AI found potential problems Dec 30, 2022

View reviewed changes

Comment thread detekt-cli/src/main/kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt Fixed

3flex force-pushed the kotlin-1.8 branch from 3b6497e to c56b9ab Compare December 30, 2022 00:54

vercel Bot deployed to Preview December 30, 2022 01:00 View deployment

3flex mentioned this pull request Dec 30, 2022

Re-enable test task in detekt-compiler-plugin #5646

Closed

3flex commented Dec 30, 2022

View reviewed changes

This was referenced Dec 30, 2022

Incompatibility with Kotlin 1.8.0 #5644

Closed

Don't silently use Kotlin compiler fallback strategy #5650

Merged

Fail build when issues found with JVM target compatibility of related compile tasks #5651

Merged

3flex added 2 commits December 30, 2022 16:21

Update list of compatible JVM targets

8b2edb8

Disable :detekt-compiler-plugin:test task

a62714b

3flex force-pushed the kotlin-1.8 branch from c56b9ab to a62714b Compare December 30, 2022 05:21

vercel Bot deployed to Preview December 30, 2022 05:28 View deployment

cortinico approved these changes Dec 30, 2022

View reviewed changes

3flex merged commit a22d301 into main Dec 30, 2022

3flex deleted the kotlin-1.8 branch December 30, 2022 10:52

Goooler mentioned this pull request Jan 27, 2023

Configure languageVersion via toolchain #5735

Closed

cortinico mentioned this pull request Mar 2, 2023

detekt task failed while using java-19 #5866

Closed

kenyee mentioned this pull request Apr 5, 2023

#unusedparameter anchor missing from web site rule docs #5964

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Kotlin to v1.8.0#5614

Update Kotlin to v1.8.0#5614
3flex merged 6 commits intomainfrom
kotlin-1.8

3flex commented Dec 8, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Dec 8, 2022 •

edited

Loading

Uh oh!

3flex commented Dec 8, 2022

Uh oh!

3flex commented Dec 10, 2022 •

edited

Loading

Uh oh!

Uh oh!

3flex Dec 30, 2022

Uh oh!

tokuhirom commented Mar 3, 2023

Uh oh!

3flex commented Mar 3, 2023

Uh oh!

eboudrant commented Mar 7, 2023 •

edited

Loading

Uh oh!

3flex commented Mar 7, 2023

Uh oh!

ravermeister commented Mar 17, 2023 •

edited

Loading

Uh oh!

3flex commented Mar 17, 2023

Uh oh!

pexa-agopalakrishnan commented Apr 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

3flex commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

3flex commented Dec 8, 2022

Uh oh!

3flex commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

3flex Dec 30, 2022

Choose a reason for hiding this comment

Uh oh!

tokuhirom commented Mar 3, 2023

Uh oh!

3flex commented Mar 3, 2023

Uh oh!

eboudrant commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

3flex commented Mar 7, 2023

Uh oh!

ravermeister commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

3flex commented Mar 17, 2023

Uh oh!

pexa-agopalakrishnan commented Apr 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

3flex commented Dec 8, 2022 •

edited

Loading

codecov Bot commented Dec 8, 2022 •

edited

Loading

3flex commented Dec 10, 2022 •

edited

Loading

eboudrant commented Mar 7, 2023 •

edited

Loading

ravermeister commented Mar 17, 2023 •

edited

Loading