Add support for MetadataType Attribute #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Fine with me Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Thank you. Much better explaination! Actually this is my first contribution to such a project... Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…gPolicyOptions.cs Fine with me Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…gPolicyOptions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…gPolicyOptions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Need additional review Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
This was referenced Dec 22, 2024
sungam3r
reviewed
Dec 22, 2024
sungam3r
reviewed
Jan 4, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 4, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 4, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 4, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Just a remark: Extension is on MemberInfo not on PropertyInfo, but its OK Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nsion.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
reviewed
Jan 5, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 5, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 5, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 5, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 5, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jan 5, 2025
src/Destructurama.Attributed/Attributed/CustomPropertyInfoExtension.cs
Outdated
Show resolved
Hide resolved
Member
|
@digitalsigi Only single conversation left - https://github.com/destructurama/attributed/pull/142/files#r1901650509 . I reviewed all files except that one test file with incomprehensible public/private properties. I'm fine to merge PR after that. |
Contributor
Author
|
I just resolved this.
Wow, would be my first PR…
Go ahead.
Von: Ivan Maximov ***@***.***>
Gesendet: Sonntag, 5. Januar 2025 16:23
An: destructurama/attributed ***@***.***>
Cc: Josef Bogad ***@***.***>; Mention ***@***.***>
Betreff: Re: [destructurama/attributed] Add support for MetadataType Attribute (PR #142)
@digitalsigi<https://github.com/digitalsigi> Only single conversation left - https://github.com/destructurama/attributed/pull/142/files#r1901650509 . I reviewed all files except that one test file with incomprehensible public/private properties. I'm fine to merge PR after that.
—
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGQGKIZW7WL6HQ4FKWNKWT2JFE6PAVCNFSM6AAAAABUBYOKEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGY3DCNJTG4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 242 259 +17
Branches 37 40 +3
=========================================
+ Hits 242 259 +17 ☔ View full report in Codecov by Sentry. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support from MetadataType Attribute, see #40
According to https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.metadatatypeattribute?view=net-9.0#remarks
The MetadataType attribute can only applied to a class
The attribute cannot be inherited by derived classes.
can only applied once
Netstandard 2.0 or below is not supported
Changed code replaces the PropertyInfo from base class with PropertyInfo property of MetadataType for equal named properties.