Support NPM cross compilation npm_config_arch + Windows arm64 support #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
Closing and re-opening PR as Travis status hangs at "in progress" while tests have passed already a while ago |
Contributor
Author
|
Travis tests passed but status isn't updated here on GitHub. Already re-opened this PR twice but doesn't help unfortunately. Please let me know if there's anything I can do from my side! |
Contributor
|
@outofambit Let me know if I can verify anything for this PR in terms of testing, I have an ARM64 Windows machine (and am eagerly awaiting this PR! 💖) |
outofambit
approved these changes
Apr 10, 2020
Contributor
outofambit
left a comment
There was a problem hiding this comment.
@dennisameling thank you for your patience! this looks like a good solution. i'm going to think a little more about how to incorporate this in our next release(s), but i expect it will go out sometime in the next week, two max.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
This PR adds support for NPM's
npm_config_archparameter for cross compilation scenarios, as well as a "workaround" for Windows arm64. Since there's no native arm64 build for Dugite Native, we can benefit from Windows' 32-bit emulation capabilities on arm64.Similar to #376, but this PR supports the industry-standard
npm_config_arch(https://www.electronjs.org/docs/tutorial/using-native-node-modules#using-npm) instead of introducing an environment variable that's only specific to Dugite.