Add ability to configure architecture to download proper Git binary #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivation is to support Dugite module on Windows on ARM64. Since Git for Windows is not available on this architecture yet, but Windows 10 allows x86 code to run on the ARM64 version of Windows 10. We should download 'win32-ia32' binary in this case. Sometimes it would be nice if the architecture could be configurable. For example Electron relies on Dugite module. To build Electron for Windows on ARM64 we use Windows x64 host machine. So during the npm install, the Dugite script downloads x64 git binary based on host arch. However that is not compatible with WoA. It needs to force to download x86 binary in this case.
4 tasks
Contributor
|
hi @kaadam, thanks for doing this work and my apologies for the long radio silence. i'm going to be merging #392 in the near-ish future. that will cover this functionality, so i'm going to close this PR. this PR was a helpful signal of interest and need for this feature and I'll be sure to give you a shout out in the release notes as well. thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation is to support Dugite module on Windows on ARM64.
Since Git for Windows is not available on this architecture yet,
but Windows 10 allows x86 code to run on the ARM64 version of Windows 10.
We should download 'win32-ia32' binary in this case. Sometimes it would be
nice if the architecture could be configurable.
For example Electron relies on Dugite module. To build Electron
for Windows on ARM64 we use Windows x64 host machine. So during the npm install,
the Dugite script downloads x64 git binary based on host arch. However
that is not compatible with WoA. It needs to force to download x86 binary in this case.