Add back "Discard all changes" context menu#7766
Merged
shiftkey merged 8 commits intodevelopmentfrom Jun 12, 2019
Merged
Conversation
…enu" This reverts commit 5bcc5e0.
Co-Authored-By: evelyn masso <outofambit@github.com>
Co-Authored-By: evelyn masso <outofambit@github.com>
tierninho
approved these changes
Jun 11, 2019
Contributor
tierninho
left a comment
There was a problem hiding this comment.
Tested the change, and all working as intended 👍
shiftkey
approved these changes
Jun 11, 2019
Contributor
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This reverts commit 5bcc5e0 to add back the "Discard all changes" context menu when right-clicking the "x files changed" header above the changes list.
Closes #7696
Description
We removed this because we got feedback that the context menu was not discoverable. We still think that's true, but we should have had a better alternative in place prior to removing this one, and that's my fault - sorry to everyone who experienced this as a regression.
We've thought about a few different options to increase discoverability, but while we're discussing it we want to ensure the experience that many people have come to expect still exists until there's a good alternative in place.
Release notes
[Added] "Discard all changes" context menu available from Changes header