Skip to content

Add tracking for RBB Lite#4439

Merged
shiftkey merged 5 commits intomasterfrom
rbb-usage-tracking
Apr 23, 2018
Merged

Add tracking for RBB Lite#4439
shiftkey merged 5 commits intomasterfrom
rbb-usage-tracking

Conversation

@iAmWillShepherd
Copy link
Contributor

@iAmWillShepherd iAmWillShepherd commented Apr 13, 2018

Fixes #4438

Plumbing

  • Add branchComparisons field to IDailyMeasures in stats database
  • Add comparisonsToMaster defaultBranchComparisons field to IDailyMeasures in stats database
  • Add mergesInitiatedFromComparison field to IDailyMeasures in stats database
  • Add updateFromDefaultBranchMenuCount field to IDailyMeasures in stats database
  • Add mergeIntoCurrentBranchMenuCount field to IDailyMeasures in stats database
  • Add methods for each new measure to statsStore
  • Add a new fields for the new measures to DefaultDailyMeasure in statsStore

Back-end (Central)

  • Add measure to desktop_usage_event.rb
  • Update usage_test.rb
  • Update fake_desktop_data in helper.rb

Database

  • Open an issue on github/analytics to get new field pulled into view, update airflow, and update reports

Other

This depends on PRs in central, desktop.github.com, and analytics being merged.

@iAmWillShepherd iAmWillShepherd added this to the 1.2.0 milestone Apr 13, 2018
@iAmWillShepherd
Copy link
Contributor Author

This branch can be merged before #4182, RBB Lite, is merged.

@iAmWillShepherd iAmWillShepherd added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 13, 2018
shiftkey
shiftkey previously approved these changes Apr 16, 2018
@shiftkey shiftkey self-assigned this Apr 16, 2018
@shiftkey shiftkey merged commit 470ea4a into master Apr 23, 2018
@shiftkey shiftkey deleted the rbb-usage-tracking branch April 23, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants