Convert the scripts to TypeScript by j-f1 · Pull Request #3675 · desktop/desktop

j-f1 · 2017-12-24T16:38:23Z

Fixes #48.

TODO:

JSDoc FTW!

Plus a few refactors

script/publish.ts

+          const input = Fs.createReadStream(assetPath)
+
+          hash.on('finish', () => {
+            const sha = hash.read().toString('hex')


package.json

    "eslint:fix": "yarn eslint --fix",
    "eslint-check": "eslint --print-config .eslintrc.* | eslint-config-prettier-check",
-    "publish": "node script/publish",
+    "publish": "ts-node script/publish",


script/debug.ts

@@ -0,0 +1,37 @@
+'use strict'


j-f1 · 2018-01-06T21:00:53Z

Depends on ~~DefinitelyTyped/DefinitelyTyped#22722~~ @types/legal-eagle getting published.

j-f1 · 2018-01-17T14:16:50Z

🔷

j-f1 · 2018-01-17T18:18:34Z

~~Can someone restart the Travis CI build?~~ Thanks!

shiftkey · 2018-05-23T05:29:38Z

a02d8c4 now merges the Webpack 4 changes into this PR, and there's a couple of type errors that are outstanding now - almost ready for another round of review!

This reverts commit f9d4740.

shiftkey · 2018-05-24T01:29:32Z

Alright, I'm dropping myself as a reviewer because I've been heavily involved in this, but I think this is close to merging in. Could someone else give this a pass and a 👍?

shiftkey · 2018-07-03T17:50:02Z

Friendly bump on this @desktop/core - would love to figure out if we can land this soon

script/start.ts

+
+import { forceUnwrap as u } from '../app/src/lib/fatal-error'
+
+import configs = require('../app/webpack.development')


script/start.ts

+
+function startApp() {
+  const runningApp = run({ stdio: 'inherit' })
+  if (!runningApp) {


tsconfig.json

+    "app/**/*.ts",
+    "app/**/*.tsx",
+    "app/**/*.d.tsx",
+    "app/webpack.*.ts"


script/publish.ts

+    s3.upload(
+      uploadParams,
+      (error: Error, data: AWS.S3.ManagedUpload.SendData) => {
+        if (error) {


script/publish.ts

-sha = sha.substr(0, 8)
+const sha = getSha().substr(0, 8)
+
+const getSecret = () => {


script/publish.ts

-cp.execSync('yarn package')
+execSync('yarn package')
+
+const getSha = () => {


script/publish.ts

 if (
  !currentTipSHA ||
-  !currentTipSHA.toUpperCase().startsWith(releaseSHA.toUpperCase())
+  !currentTipSHA.toUpperCase().startsWith(releaseSHA!.toUpperCase())


shiftkey · 2018-07-06T15:30:06Z

Thanks @j-f1 for this work!

j-f1 added 7 commits December 24, 2017 11:27

Integrate the T Y P E S directly into *-info.js

a23a482

JSDoc FTW!

Convert the webpack configs to TS ✨

7bf7197

Convert dev-commands-global.ts to TS

ee1dc7b

TSify app-info.ts

d88773a

Plus a few refactors

Fix the 📖

8e5d6ec

TSify some more scripts

2a7a790

Refactor webpack.*.js exports

d279eca

j-f1 commented Dec 24, 2017

View reviewed changes

teetsmelange approved these changes Dec 30, 2017

View reviewed changes

teetsmelange previously approved these changes Dec 30, 2017

View reviewed changes

j-f1 and others added 3 commits December 31, 2017 17:53

Fix yarn run publish

a86efb6

Happy, TS?

d3dcbb6

liiint

1929e7d

shiftkey reviewed Jan 1, 2018

View reviewed changes

package.json Outdated

"eslint:fix": "yarn eslint --fix",

"eslint-check": "eslint --print-config .eslintrc.* | eslint-config-prettier-check",

"publish": "node script/publish",

"publish": "ts-node script/publish",

This comment was marked as spam.

Sign in to view

shiftkey reviewed Jan 1, 2018

View reviewed changes

script/debug.ts Outdated

@@ -0,0 +1,37 @@

'use strict'

This comment was marked as spam.

Sign in to view

j-f1 added 3 commits January 1, 2018 16:20

Add .ts extension

41d6c21

⬆️ TS ESLint parser for bug fix

d1668da

Enforce 'use strict' (non-)use

53d8d52

j-f1 added 7 commits January 17, 2018 07:18

Merge branch 'master' into my-hands-are-typing

d503f0e

Use the legal-eagle TYPES

3d874ab

⬆️ TS ESLint parser

431de33

Run the scripts with the -P script option

47748c0

TSify git-info and package-info

1c84ec7

🔥 'use strict';

05c35ea

TSify dist-info

07ed34c

'use (modules are already) strict'

be47bfe

shiftkey dismissed teetsmelange’s stale review via a02d8c4 May 23, 2018 05:27

fixing up some T Y P E S

e5652d3

iAmWillShepherd removed their assignment May 23, 2018

shiftkey added 5 commits May 24, 2018 10:13

avoid the cast, use the bang

56dc464

make this failure a bit more clear

0686c8e

lift this up to the file header

f9d4740

tidy up this bit of type annotation

e7b8514

Revert "lift this up to the file header"

b0c34b1

This reverts commit f9d4740.

shiftkey removed their assignment May 24, 2018

shiftkey added 5 commits June 6, 2018 17:44

Merge branch 'master' into pr/3675

a4b8d23

Merge branch 'master' into pr/3675

782c08c

Merge branch 'master' into pr/3675

87cc7b9

Merge branch 'master' into pr/3675

e4f7c37

Merge branch 'master' into pr/3675

7d1dee5

iAmWillShepherd reviewed Jul 3, 2018

View reviewed changes

iAmWillShepherd suggested changes Jul 3, 2018

View reviewed changes

iAmWillShepherd self-assigned this Jul 3, 2018

Address review comments

0cabb14

iAmWillShepherd approved these changes Jul 5, 2018

View reviewed changes

iAmWillShepherd merged commit 80791f1 into desktop:master Jul 6, 2018

j-f1 deleted the my-hands-are-typing branch July 6, 2018 14:53

shiftkey mentioned this pull request Jul 6, 2018

test deploy with updated scripts #5109

Merged

lock bot added the locked-due-to-inactivity label Sep 4, 2018

lock bot locked as resolved and limited conversation to collaborators Sep 4, 2018

shiftkey removed the locked-due-to-inactivity label Sep 27, 2018

desktop unlocked this conversation Sep 27, 2018


		import { forceUnwrap as u } from '../app/src/lib/fatal-error'

		import configs = require('../app/webpack.development')

Conversation

j-f1 commented Dec 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

j-f1 commented Jan 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

j-f1 commented Jan 17, 2018

Uh oh!

j-f1 commented Jan 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shiftkey commented May 23, 2018

Uh oh!

shiftkey commented May 24, 2018

Uh oh!

shiftkey commented Jul 3, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shiftkey commented Jul 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

j-f1 commented Dec 24, 2017 •

edited

Loading

j-f1 commented Jan 6, 2018 •

edited

Loading

j-f1 commented Jan 17, 2018 •

edited

Loading