Skip to content

Add legal-eagle#22722

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
j-f1:add-legal-eagle
Jan 7, 2018
Merged

Add legal-eagle#22722
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
j-f1:add-legal-eagle

Conversation

@j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 6, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@j-f1 j-f1 closed this Jan 6, 2018
@j-f1 j-f1 reopened this Jan 6, 2018
@j-f1
Copy link
Contributor Author

j-f1 commented Jan 6, 2018

Any ideas why this is failing?

@GlenCFL
Copy link
Contributor

GlenCFL commented Jan 7, 2018

That's probably an issue with Travis. I'd try amending that commit in order to get Travis to run again.

@mhegazy mhegazy merged commit bb43bdb into DefinitelyTyped:master Jan 7, 2018
@j-f1 j-f1 deleted the add-legal-eagle branch January 7, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants