Skip to content

Conversation

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 21, 2017

After uncovering that I'd broken the app completely for Linux users in #2807, I'd like to get us back and running tests on Travis against the Linux version so we catch these earlier.

I've disabled publishing for now to ensure we don't accidentally publish things, but once we start exploring the packaging stuff again in #2300 and ensure our update server can consume new releases we can start talking about what official support looks like.

@shiftkey
Copy link
Member Author

@joshaber I couldn't spot the right option to re-enable builds on Travis. You mentioned disabling this when we switched over to CircleCI. Mind doing the needful if we're 👍 on this PR?

@shiftkey
Copy link
Member Author

An example of this successful build: https://travis-ci.org/shiftkey/desktop/builds/278022535

@shiftkey shiftkey added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 21, 2017
addons:
apt:
packages:
# by default the container VMs have Git 1.9.1, ermagherd...

This comment was marked as spam.

Copy link
Contributor

@joshaber joshaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build's running now. Feel free to merge when it passes.

@joshaber
Copy link
Contributor

💃

@joshaber joshaber merged commit a024400 into master Sep 21, 2017
@joshaber joshaber deleted the cleanup-travis-config-for-linux branch September 21, 2017 12:27
@shiftkey shiftkey mentioned this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants