don't crash the app on non-macOS and non-Windows platforms #2807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
reviewed
Sep 21, 2017
app/src/lib/editors/lookup.ts
Outdated
| } | ||
|
|
||
| return Promise.reject( | ||
| log.warn( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #2407 as fallback behaviour where we hadn't implemented a way to resolve available editors on an given platform.
Unfortunately in #2611 these checks were now performed in
AppStore.loadInitialState(), so the error wasn't handled which meant it would fail before it had a chance to show some UI about the error.For now I've swapped this out to a warning and empty list, which has the same result but with 100% less crashing.
There's also some unused code in here that I've 🔥d.