Sorry about that! Will do from now on. Here's an updated PR.

Looks good, thanks again @ptomato!

Can you do an AppImage too? That way it will run also where Flatpak is not installed.

My understanding there was already an AppImage on @gengjiawen's fork. In any case, I'm really only interesting in packaging for Flatpak right now, but these improvements should help anyone else who wants to take on other packaging tasks.

The terminal part we can learn from vs code: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/execution/electron-browser/terminalService.ts#L199.

I've been unsuccesul trying to build this.

[WEBPACK] Finished building main.js within 30.148 seconds

[at-loader] Checking started in a separate process...

[at-loader] Ok, 3.342 sec.
[WEBPACK] Build failed after 38.972 seconds
[WEBPACK] Errors building crash.js
Module not found: Error: Can't resolve '../build/Release/runas.node' in '/home/djpate/desktop/app/node_modules/runas/lib'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ compile:prod: `cross-env NODE_ENV=production parallel-webpack --config app/webpack.production.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @ compile:prod script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/djpate/.npm/_logs/2017-07-24T12_52_22_799Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ build:prod: `npm run compile:prod && cross-env NODE_ENV=production node script/build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @ build:prod script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/djpate/.npm/_logs/2017-07-24T12_52_22_825Z-debug.log

I've tried to clean all my npm modules, install runas globally etc but no luck.

Any clues?

@shiftkey Do you think we can make Open in terminal function as a common npm library as like desktop/dugite?

@gengjiawen without knowing about other use cases I'd rather it get refined and expanded on here (we've got #888 to tackle soon) before we extract, rather than doing it before it's ready.

I mean I'm very late, but can't you simply use x-terminal-emulator? (x-terminal-emulator is configured by update-alternatives) It is at least on Ubuntu present and opens the preferred terminal and do the more complicated methods only, if not present? The problem with hard coding is that for example mate-terminal is not present although Ubuntu mate is a official distribution of Ubuntu.

@cromefire Desktop is currently interested in displaying a list of shells that it can find on your machine for your convenience. Please read our documentation about how this currently works on Linux (as well as the other platforms).

This issue was about changes to the whole app to make it work on Linux - we haven't really talked about "preferred shells" in any detail. Please read the documentation around our Linux testing effort as that explains the best place to leave additional feedback currently.

Just meant because update-alternatives --list x-terminal-emulator lists the available shells.
The interface is by the way the same for all (gnome-terminal is also on the list so why don't replace gnome-terminal with x-terminal-emulator as it is the standard way)