Fix JetBrains Toolbox IDEs detection#21643
Merged
sergiou87 merged 1 commit intodevelopmentfrom Feb 19, 2026
Merged
Conversation
Stop relying on a captured group from the registry key name; instead read the DisplayName value directly for JetBrains Toolbox entries. The regex was simplified (no capture group), code now looks up DisplayName from the uninstall key, logs and skips entries missing DisplayName, and uses that value for displayNamePrefixes. This makes editor detection more robust when the key name doesn't match the product display name.
niik
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21498
Description
Before this PR, we expected these IDEs to have registry keys like "JetBrains Toolbox () " and then find that
<PRODUCT NAME>to be theDisplayNameregistry value, however that changed at some point, and we can find something like:JetBrains Toolbox (PyCharm-P)and DisplayNamePyCharmJetBrains Toolbox (IDEA)and DisplayNameIntelliJ IDEAJetBrains Toolbox (Goland)and DisplayNameGoLand(GolandvsGoLand)The new logic implemented in this PR just takes whatever is in
DisplayName, so the detection of these IDEs will rely mainly on the main key regex (/^JetBrains Toolbox (…) …/) and the publisher.Release notes
Notes: [Fixed] Fix detection of IDEs installed from JetBrains Toolbox