Merged
Conversation
Closed
Merged
sergiou87
requested changes
Jan 28, 2026
app/src/lib/git/pull.ts
Outdated
Comment on lines
+56
to
+57
| 'prepare-commit-msg', | ||
| 'commit-msg', |
Member
There was a problem hiding this comment.
These two are duplicated and can be deleted, right?
Suggested change
| 'prepare-commit-msg', | |
| 'commit-msg', |
app/src/lib/git/pull.ts
Outdated
| ...gitRebaseArguments(), | ||
| 'pull', | ||
| ...(await getDefaultPullDivergentBranchArguments(repository)), | ||
| ...(enableRecurseSubmodulesFlag() ? ['--recurse-submodules'] : []), |
Member
There was a problem hiding this comment.
This feature flag got removed in development with #21188
Suggested change
| ...(enableRecurseSubmodulesFlag() ? ['--recurse-submodules'] : []), | |
| '--recurse-submodules', |
sergiou87
approved these changes
Jan 29, 2026
Member
sergiou87
left a comment
There was a problem hiding this comment.
Code looks good and I did some testing, it seems to work as expected! 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #21461
Screenshots
Release notes
Notes: