Disable pointer events for checkmark octicons in diff#19304
Merged
sergiou87 merged 1 commit intodevelopmentfrom Sep 24, 2024
Merged
Disable pointer events for checkmark octicons in diff#19304sergiou87 merged 1 commit intodevelopmentfrom
sergiou87 merged 1 commit intodevelopmentfrom
Conversation
tidy-dev
approved these changes
Sep 24, 2024
Contributor
tidy-dev
left a comment
There was a problem hiding this comment.
✨ This feels like deja vu... good fix.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19302
Description
This PR disables the pointer events on the checkmark octicons so right-clicks can go through them and be captured by our event handlers.
Screenshots
Screen.Recording.2024-09-24.at.12.16.03.mov
Release notes
Notes: [Fixed] Right-clicking on diff checkmarks displays the context menu