-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Closed
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugspriority-3Bugs that affect small number of users and/or relatively cosmetic in natureBugs that affect small number of users and/or relatively cosmetic in nature
Description
The problem
When in the diff view of a file, you can normally right-click on/near the line numbers to discard changes for a line or group of lines. Since the introduction of the new accessibility feature "Show check marks in the diff" was added, you cannot right-click over the check marks.
You now have to right-click in an area around them for it to work, and right-clicking directly on the check marks does not do anything. This also makes it really difficult to right click on single line diffs, as the check mark takes up most of the clickable space. See the gif below for a demo of the problem.
Release version
3.4.5
Operating system
Windows 11 Pro Version 23H2
Steps to reproduce the behavior
- Turn on the "Show check marks in the diff" accessibility feature in the GitHub Desktop settings.
- Make changes on a tracked file.
- Open file in diff view in GitHub Desktop.
- Attempt to right-click on the check marks to discard line changes.
- Notice that the normal popup to discard line(s) does not appear.
Log files
2024-09-23.desktop.production.log
Screenshots
Additional context
Occurs in both unified and split diff display modes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugspriority-3Bugs that affect small number of users and/or relatively cosmetic in natureBugs that affect small number of users and/or relatively cosmetic in nature
