Mark the AutocompletingTextInput Popover as not dialog#19114
Merged
sergiou87 merged 1 commit intodevelopmentfrom Aug 19, 2024
Merged
Mark the AutocompletingTextInput Popover as not dialog#19114sergiou87 merged 1 commit intodevelopmentfrom
sergiou87 merged 1 commit intodevelopmentfrom
Conversation
tidy-dev
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/8567
Description
After the changes in #17733, Popovers, by default, have a
role="dialog", and that includes the popover used in theAutocompletingTextInput. This PR changes theisDialogprop tofalsein theAutocompletingTextInputcomponent to mark the popover as not a dialog.Release notes
Notes: [Fixed] Remove "dialog" role from the autocompletion suggestions popover