Skip to content

Improve reorder commits hint#17733

Merged
tidy-dev merged 6 commits intodevelopmentfrom
improve-reorder-commits-hint
Nov 20, 2023
Merged

Improve reorder commits hint#17733
tidy-dev merged 6 commits intodevelopmentfrom
improve-reorder-commits-hint

Conversation

@sergiou87
Copy link
Member

@sergiou87 sergiou87 commented Nov 16, 2023

xref. https://github.com/github/accessibility-audits/issues/5715

Description

This PR sits on top of #17671 and, with @tidy-dev 's help, improves the look & feel and aria semantics of the reorder commits hint by:

  • Not displaying the hint as a balloon (although still keeping rounded corners to make it slightly different from the other elements on the screen)
  • Showing a title in the hint for extra context
  • Use key icons instead of text. I chose to replace the text with the icons to keep the verbiage short (and I think it looks nice too 😳)
  • Also adapt verbiage for screen readers ("choose new location" instead of "move commits")
  • Remove dialog aria semantics from this specific popover

Screenshots

image

Release notes

Notes: no-notes

tidy-dev and others added 5 commits November 13, 2023 09:51
Base automatically changed from reorder-with-keyboard to development November 16, 2023 14:50
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Looks great! Thanks for iterating on this. :)

@tidy-dev tidy-dev merged commit 43cc52a into development Nov 20, 2023
@tidy-dev tidy-dev deleted the improve-reorder-commits-hint branch November 20, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants