Conversation
eafa086 to
7e3818a
Compare
7e3818a to
5e4ff48
Compare
547ab4a to
f57d8c8
Compare
f57d8c8 to
f731534
Compare
nbolton
previously approved these changes
Jun 9, 2025
2368d8e to
cd333d0
Compare
cd333d0 to
00dc4d5
Compare
00dc4d5 to
12cc2d6
Compare
12cc2d6 to
63cc5a1
Compare
63cc5a1 to
d92a6d1
Compare
whot
approved these changes
Jun 9, 2025
Contributor
whot
left a comment
There was a problem hiding this comment.
A few typos but otherwise this LGTM (ignoring my lack of deep cmake knowledge).
d92a6d1 to
1f88a75
Compare
Member
Author
|
Thanks @whot i've fixed those issues |
1f88a75 to
ee49347
Compare
nbolton
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESKFLOW_RESET_ALLenv var mention from the configuration.md , this should have been part of Deskflow-gui addresetoption #8563doc/userdoc/devfor dev docs@whot if you like to check this out. this is how we intend to deploy the "developer" documentation
@laz-001 Please rebase your protocol updates on this when it lands. (should not take long)