Skip to content

Deskflow-gui add reset option#8563

Merged
nbolton merged 1 commit intomasterfrom
resetOption
May 3, 2025
Merged

Deskflow-gui add reset option#8563
nbolton merged 1 commit intomasterfrom
resetOption

Conversation

@sithlord48
Copy link
Copy Markdown
Member

Remove the use of the environmental variable DESKFLOW_RESET_ALL and reset instead when --reset is passed as an option.

@sithlord48 sithlord48 requested a review from nbolton May 2, 2025 11:37
Copy link
Copy Markdown
Member

@nbolton nbolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Help' -> 'Clear settings' stopped working because it uses --no-reset

// prevent infinite reset loop when env var set.
arguments << "--no-reset";

@sithlord48 sithlord48 force-pushed the resetOption branch 2 times, most recently from 629e472 to c3d3fcf Compare May 2, 2025 13:16
@sithlord48
Copy link
Copy Markdown
Member Author

The 'Help' -> 'Clear settings' stopped working because it uses --no-reset

// prevent infinite reset loop when env var set.
arguments << "--no-reset";

Adjusted this check

@sithlord48 sithlord48 requested a review from nbolton May 2, 2025 13:19
@sithlord48 sithlord48 added the ✨ enhancement A suggested change to improve functionality label May 2, 2025
@nbolton nbolton merged commit 9034017 into master May 3, 2025
32 checks passed
@nbolton nbolton deleted the resetOption branch May 3, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement A suggested change to improve functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants