Replace Windows daemon TCP IPC with Qt local server/sockets#8180
Merged
Replace Windows daemon TCP IPC with Qt local server/sockets#8180
Conversation
b0020e8 to
adb5732
Compare
This comment was marked as outdated.
This comment was marked as outdated.
adb5732 to
a80b1b4
Compare
This was referenced Feb 11, 2025
12 tasks
7e23855 to
67ecd93
Compare
This was referenced Feb 19, 2025
12 tasks
b760db7 to
cdda4c1
Compare
b52f9f9 to
7e18c2b
Compare
Windows file logger and `OutputDebugString` already add new lines, so remove the ones added by the Core.
… shutdown handling
…re count when no command is set
…d shorter sleep times
sithlord48
approved these changes
Feb 28, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7804
Blocker:
I had initially planned to not make the daemon a Qt app, but due to Windows permissions, IPC was the best solution--which, I remember now, is the reason why I used IPC in the first place. The Qt implementation of IPC should be much more reliable and easier to maintain than the old version (which re-used the existing TCP code, mostly out of laziness).
Now, instead of sending log data from the daemon over IPC--overkill--the daemon simply tells the GUI the path of the daemon log, which the GUI then tails.
I also disabled the(moving this to new PR)deskflow-server,deskflow-client, anddeskflow-daemonbinaries in favor of one:deskflow-coreTODO:
deskflow-daemonwith original switchesdeskflow-serveranddeskflow-clientFix fingerprint dialog bug(extracted: Remove Core stop/start for fingerprint dialog #8251)