Skip to content

Fixed log outputter double-free and event loop cond var access violation#8266

Merged
nbolton merged 6 commits intomasterfrom
fix8265
Feb 28, 2025
Merged

Fixed log outputter double-free and event loop cond var access violation#8266
nbolton merged 6 commits intomasterfrom
fix8265

Conversation

@nbolton
Copy link
Copy Markdown
Member

@nbolton nbolton commented Feb 28, 2025

Fixes:

TODO:

  • FIx outputter double-free
  • Fix event loop cond var access violation

sithlord48
sithlord48 previously approved these changes Feb 28, 2025
@sithlord48 sithlord48 self-requested a review February 28, 2025 12:36
… to top of stack in Windows daemon

This is how we do it in the server/client apps, so it makes sense to mirror the same pattern.
@nbolton
Copy link
Copy Markdown
Member Author

nbolton commented Feb 28, 2025

@sithlord48 I clicked the 'Ready for review' button. PR is now ready for review.

@nbolton nbolton enabled auto-merge (rebase) February 28, 2025 12:49
Copy link
Copy Markdown
Member

@sithlord48 sithlord48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me Tested on linux without issue

@nbolton nbolton merged commit 0fc5368 into master Feb 28, 2025
33 of 56 checks passed
@nbolton nbolton deleted the fix8265 branch February 28, 2025 12:57
@nbolton nbolton changed the title Improve log outputter and usage to avoid future memory bugs Fixed log outputter double-free and event loop cond var access violation Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants