@nbolton There are many ways to award the bounty.
/claim in the PR description will automate without any hustle.

And another way is /tip $X @contributor depends on our convience

please do not fix commits with more commits

@sithlord48 Just I will squash the commits at last :)

@nbolton @sithlord48 Sorry for the noise here as my storage space in my PC is mostly full and I can't build it locally and push it here so I am testing it here.

@sithlord48 I hope your guidance makes more sense here. There is field data in FingerprintData struct but build failing can't access it

@sithlord48 The error occurring due to OpenSSL dependency

i do remember having to deal with this i think in input-leap.

have not had time to look at the code buty
deskflow::format_ssl_fingerprint[abi:cxx11](std::vector<unsigned char, std::allocator<unsigned char> > const&, bool)
stands out to me iirc that function takes a (std::vector<uint8_t , bool) is the input proper ?

Looking over the code just a note , please use #pragma once instead of #if / #ifdef #endif

@sithlord48 Is this due to import issues?

@sithlord48 One error left of build failed of not getting compiled of Arch.h which isn't affected with any changes here

I've just noticed that there are some issues with the Common library in this PR . it can't be an INTERFACE if it has cpp files taht need building.
that could be part of your issue.

@varshith257 Need any help from us to get this PR landed?

@nbolton Mostly it is done and a fix is needed of not getting compiled of Arch.h which isn't affected with any changes here

@nbolton All workflows are passing. I think its ready to merge

/tip $200 @sithlord48

@sithlord48: You just got a $200 tip! 👉 Complete your Algora onboarding to collect your payment.

🎉🎈 @sithlord48 has been awarded $200! 🎈🎊

• Share on socials
• Give feedback

@sithlord48 @nbolton Do we need any changes here or can be merged?

@sithlord48 @nbolton Do we need any changes here or can be merged?

Testing now, thanks for your patience.

@varshith257 This kind of error tells me that you are not testing your changes locally, which breaks the rules of our hacking guide: 3. Open PRs must be tested and must compile

Please do not use our CI as your compiler, as this wastes time for maintainers. Test your changes locally before pushing.

FAILED: src/lib/net/CMakeFiles/net.dir/FingerprintDatabase.cpp.o 
/usr/sbin/c++ -DHAVE_CONFIG_H -DHAVE_GDK_PIXBUF=1 -DHAVE_LIBNOTIFY=1 -DNDEBUG -DSYSAPI_UNIX=1 -DWINAPI_XWINDOWS=1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/__w/deskflow/deskflow/src/./lib -I/__w/deskflow/deskflow/build/src/lib -fPIC -O3 -DNDEBUG -std=c++20 -Werror -MD -MT src/lib/net/CMakeFiles/net.dir/FingerprintDatabase.cpp.o -MF src/lib/net/CMakeFiles/net.dir/FingerprintDatabase.cpp.o.d -o src/lib/net/CMakeFiles/net.dir/FingerprintDatabase.cpp.o -c /__w/deskflow/deskflow/src/lib/net/FingerprintDatabase.cpp
/__w/deskflow/deskflow/src/lib/net/FingerprintDatabase.cpp: In member function ‘void deskflow::FingerprintDatabase::read(const std::filesystem::__cxx11::path&)’:
/__w/deskflow/deskflow/src/lib/net/FingerprintDatabase.cpp:18:3: error: ‘open_utf8_path’ was not declared in this scope; did you mean ‘openUtf8Path’?
   18 |   open_utf8_path(file, path, std::ios_base::in);
      |   ^~~~~~~~~~~~~~
      |   openUtf8Path
/__w/deskflow/deskflow/src/lib/net/FingerprintDatabase.cpp: In member function ‘void deskflow::FingerprintDatabase::write(const std::filesystem::__cxx11::path&)’:
/__w/deskflow/deskflow/src/lib/net/FingerprintDatabase.cpp:25:3: error: ‘open_utf8_path’ was not declared in this scope; did you mean ‘openUtf8Path’?
   25 |   open_utf8_path(file, path, std::ios_base::out);
      |   ^~~~~~~~~~~~~~
      |   openUtf8Path

It does not compile on any OS.

@varshith257 Heads up, I'm going to force push some changes to your branch.

I changed the title as I can't see how this fixes any CVEs.

I removed the bounty claim as the issue is nowhere near fixed by this PR.

@nbolton Me and @sithlord48 aggreed upon I will work on supporting FingerPrintDataBase and @sithlord48 had already worked fixing this CVE of adding peer identity before the bounty enabled and we agreed upon the same of using fingerprintdatabse and I landed this PR

This PR was reverted: #8149

Landing it in the first place was a mistake.