Oh, its finally ready! Will try to review tomorrow.

I am concerned that this will confuse users. Why would they need to click this button when they are on this dialog?

It's likely in my experience that they will click it and think, "Hey those don't match" to which we will respond "Of course they don't match, they're not supposed to"... and we'll repeat that response until ultimately we remove the button as we tire of this discussion.

TL;DR: People don't read things and will end up wasting our time with questions that don't make sense.

Please make sure your using the newest version .
that dialog popup should be fixed. you can test it by removing the ~/.config/Deskflow/deskflow.pem . or with a clean install on a machine with no previous settings.

I am concerned that this will confuse users. Why would they need to click this button when they are on this dialog?

With the dialog up there is no way to see your local keys to confirm what is on the screen in the case a new server connecting to a new client both will have the dialog up showing the others keys with no way to view their own. I do not want to add the local keys into dialog as having to see them to compare can happen in cases where you are not needing to see the local ones for example a known client or sever generates new keys.

I'd welcome some better tooltip wording for the tooltip

Ideally we could tell the app when this needs to happen and have one machine show the dialog with the remote keys while the remote shows it keys on its screen for easier comparison. But since the remote machine is not even aware of the connection status is in a need auth state to show this dialog. so i opted to allow the user to open it from the remote box.

With the dialog up there is no way to see your local keys to confirm what is on the screen in the case a new server connecting to a new client both will have the dialog up showing the others keys with no way to view their own. I do not want to add the local keys into dialog as having to see them to compare can happen in cases where you are not needing to see the local ones for example a known client or sever generates new keys.

Which problem are we trying to solve?

1. In case of a MITM, the user will see this dialog abruptly, and because they can't see what their existing client-side fingerprint was (to compare with the server) they may be tricked into thinking that the fingerprint hasn't changed.
2. When the client connects and you see the dialog on the server, you cannot check your local fingerprints to ensure that the fingerprint on the client side is valid.

In both cases, I see the value of the button but I still think the wording will confuse some people.

I also think that the word "this" will cause confusion: Does "this computer" mean the client that is connecting or this current computer that I'm on? To us devs, it's obviously this current computer that I'm on but that's because we know how it works.

With the dialog up there is no way to see your local keys to confirm what is on the screen in the case a new server connecting to a new client both will have the dialog up showing the others keys with no way to view their own. I do not want to add the local keys into dialog as having to see them to compare can happen in cases where you are not needing to see the local ones for example a known client or sever generates new keys.

Which problem are we trying to solve?

1. In case of a MITM, the user will see this dialog abruptly, and because they can't see what their existing client-side fingerprint was (to compare with the server) they may be tricked into thinking that the fingerprint hasn't changed.

2. When the client connects and you see the dialog on the server, you cannot check your local fingerprints to ensure that the fingerprint on the client side is valid.

In both cases, I see the value of the button but I still think the wording will confuse some people.

I also think that the word "this" will cause confusion: Does "this computer" mean the client that is connecting or this current computer that I'm on? To us devs, it's obviously this current computer that I'm on but that's because we know how it works.

Yes lets word it better

When I accept the dialog on the client, I see the usual message to add the client:

Edit Solved this by adding a bool to the method that makes the dialog

• When False (the default) we show the above dialog.
• When True, (only when tls enabled and require peer certificates) we show a simple information box saying the new client has to be added to the screen layout, When the user closes that dialog they are taken to the add screens dialog.

/tip $100 @sithlord48

🎉🎈 @sithlord48 has been awarded $100! 🎈🎊

• Share on socials
• Give feedback

@sithlord48 The milestone set for this PR (2.0.0) may be causing some confusion. We should review what issues/PRs are in 2.0.0 milestone.

This is a goal we need to completed before 2.0.0 can be released.. We don't hold code back for a specific release we just land it when ready and our milestones act as a guide for us to know when we can say we can bump to version ...