Skip to content

fix view sorting being reset#2736

Merged
derailed merged 1 commit intoderailed:masterfrom
wjiec:bugfix/view-reset
Jun 15, 2024
Merged

fix view sorting being reset#2736
derailed merged 1 commit intoderailed:masterfrom
wjiec:bugfix/view-reset

Conversation

@wjiec
Copy link
Contributor

@wjiec wjiec commented Jun 11, 2024

this PR fixes #2734.

When the Init method in the view.Table object is executed, the app.RefreshCustomViews method is called to reload the custom view, which triggers the ViewSettingsChanged event, ultimately causes the ui.Table object to reset the sorting of the user settings.

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Good catch! Thanks for the updates + cleanup Jayson!!

@derailed derailed merged commit 7380be9 into derailed:master Jun 15, 2024
@derailed derailed mentioned this pull request Jun 15, 2024
@wjiec wjiec deleted the bugfix/view-reset branch June 16, 2024 13:21
rm-hull added a commit to rm-hull/k9s that referenced this pull request Aug 12, 2024
* 'master' of github.com:derailed/k9s: (169 commits)
  fix: align build image Go version with go.mod (derailed#2812)
  Bump github.com/docker/docker (derailed#2816)
  Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (derailed#2813)
  Add comment about Escape keybinding (derailed#2817)
  proper handle OwnerReference for manually created job (derailed#2772)
  [derailed#2773] fix freebsd build failure (derailed#2775)
  install copyright file into correct location (derailed#2780)
  fix status for completed pods in workload view (derailed#2729)
  update deps
  [Maint] Bump grype rev
  K9s/release v0.32.5 (derailed#2740)
  --- (derailed#2707)
  fix view sorting being reset (derailed#2736)
  use policy/v1 instead of policy/v1beta1 (derailed#2732)
  Bump alpine from 3.19.1 to 3.20.0 (derailed#2721)
  fix: jump to namespaceless owner reference (derailed#2718)
  feat: Add plugins for argo-rollouts (derailed#2711)
  Bump golangci/golangci-lint-action from 5.1.0 to 6.0.1 (derailed#2702)
  allow jumping to the owner of the resource (derailed#2700)
  fix: job color based on failures (derailed#2686) (derailed#2698)
  ...
thorbenbelow pushed a commit to thorbenbelow/k9s that referenced this pull request Nov 10, 2024
aeltai pushed a commit to aeltai/rk9s that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect pod containers displayed when using custom resource columns

2 participants