Skip to content

fix(rgaa): adjust mapping of aria-hidden-* and valid-lang#4935

Merged
WilcoFiers merged 2 commits intodevelopfrom
rgaa-tag-update
Nov 17, 2025
Merged

fix(rgaa): adjust mapping of aria-hidden-* and valid-lang#4935
WilcoFiers merged 2 commits intodevelopfrom
rgaa-tag-update

Conversation

@WilcoFiers
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers commented Nov 11, 2025

Map aria-hidden-body and aria-hidden-focus to RGAA test 10.8.1 and valid-lang to RGAA 8.8.1

Closes: #4926

@WilcoFiers WilcoFiers requested a review from a team as a code owner November 11, 2025 15:31
Copilot AI review requested due to automatic review settings November 11, 2025 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects RGAA (Référentiel Général d'Amélioration de l'Accessibilité) test mappings for three accessibility rules to align with the proper RGAA v4 specifications.

  • Updated valid-lang rule mapping from RGAA 8.7.1 to 8.8.1
  • Updated aria-hidden-focus rule mapping from RGAA 7.1.1 to 10.8.2
  • Updated aria-hidden-body rule mapping from RGAA 7.1.1 to 10.8.1

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/rules/valid-lang.json Updates RGAA mapping from 8.7.1 to 8.8.1 for language attribute validation
lib/rules/aria-hidden-focus.json Updates RGAA mapping from 7.1.1 to 10.8.2 for aria-hidden focusable element checks
lib/rules/aria-hidden-body.json Updates RGAA mapping from 7.1.1 to 10.8.1 for aria-hidden on document body checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
@WilcoFiers WilcoFiers requested a review from straker November 13, 2025 18:45
@WilcoFiers WilcoFiers merged commit 77571f2 into develop Nov 17, 2025
34 checks passed
@WilcoFiers WilcoFiers deleted the rgaa-tag-update branch November 17, 2025 15:55
This was referenced Jan 5, 2026
WilcoFiers added a commit that referenced this pull request Jan 6, 2026
###
[4.11.1](v4.11.0...v4.11.1)
(2026-01-06)

### Bug Fixes

- allow shadow roots in axe.run contexts
([#4952](#4952))
([d4aee16](d4aee16)),
closes [#4941](#4941)
- color contrast fails for oklch and oklab with none
([#4959](#4959))
([8f249fd](8f249fd))
- **color-contrast:** do not incomplete on textarea
([#4968](#4968))
([d271788](d271788)),
closes [#4947](#4947)
- **commons/color:** Match browser behavior for out-of-gamut oklch
colors ([#4908](#4908))
([5036be8](5036be8))
- don't runs rules that select `html` on nested `html` elements
([#4969](#4969))
([1e9a5c3](1e9a5c3))
- replaced luminance threshold constant 0.03928 with 0.04045
([#4934](#4934))
([316967d](316967d)),
closes [#4933](#4933)
- **rgaa:** adjust mapping of aria-hidden-\* and valid-lang
([#4935](#4935))
([77571f2](77571f2))
- **valid-lang:** update valid-langs for newer language codes
([#4966](#4966))
([c3f5446](c3f5446)),
closes [#4963](#4963)

This PR was opened by a robot 🤖 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RGAA mapping may have some issues

3 participants