docs(contributing): add info about structure, import, and philosophy of axe-core development#4758
Merged
docs(contributing): add info about structure, import, and philosophy of axe-core development#4758
Conversation
…of axe-core development
scottmries
reviewed
Apr 25, 2025
dbjorge
approved these changes
Apr 28, 2025
Contributor
dbjorge
left a comment
There was a problem hiding this comment.
This is a good improvement, thanks!
It'd be great if a followup PR could enforce some of these conventions rather than just documenting them. In particular:
- The "no Virtual Nodes in utils" rule could probably be enforced (at least in a best-effort manner) by
no-restricted-syntax - The import requirements could probably be enforced by eslint rules
no-restricted-importsand/ororimport/no-restricted-paths
Contributor
Author
|
I like those ideas! |
straker
added a commit
that referenced
this pull request
Sep 24, 2025
Adds eslint rules to restrict import paths from #4758, as well as virtual node use in utils. --------- Co-authored-by: Dylan Barrell <dylan@barrell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to add some information about developing in axe-core.