Skip to content

docs: Update rule-descriptions.md to include link to ACT#4633

Merged
straker merged 3 commits intodequelabs:developfrom
mgifford:patch-2
Jan 20, 2025
Merged

docs: Update rule-descriptions.md to include link to ACT#4633
straker merged 3 commits intodequelabs:developfrom
mgifford:patch-2

Conversation

@mgifford
Copy link
Copy Markdown
Contributor

@mgifford mgifford commented Nov 8, 2024

Good to put in a link to ACT

Just adding a link as it wasn't clear to someone new to this.

Good to put in a link to ACT
@mgifford mgifford requested a review from a team as a code owner November 8, 2024 20:06
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. This is a generated file though. We'll have to make the change here in order for it not to get clobbered next time someone updates a rule:

https://github.com/dequelabs/axe-core/blob/develop/build/configure.js#L19

@straker
Copy link
Copy Markdown
Contributor

straker commented Jan 8, 2025

@mgifford any update on this pr?

@mgifford
Copy link
Copy Markdown
Contributor Author

mgifford commented Jan 9, 2025

@straker I think this is waiting for the next build. Something @WilcoFiers would have more influence over. I'm just a very satisfied user.

@WilcoFiers
Copy link
Copy Markdown
Contributor

@mgifford this isn't waiting for a build. To get this in you'll have to make the change here instead of where you put it now:
https://github.com/dequelabs/axe-core/blob/develop/build/configure.js#L19

Removing change here.
Updating patch as directed in conversation.
@mgifford
Copy link
Copy Markdown
Contributor Author

Ok, @WilcoFiers I moved the patch. Hopefully that works.

@straker straker changed the title Update rule-descriptions.md docs: Update rule-descriptions.md to include link to ACT Jan 14, 2025
Copy link
Copy Markdown
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the pr.

Reviewed for security.

@straker straker merged commit af05d88 into dequelabs:develop Jan 20, 2025
straker pushed a commit that referenced this pull request Mar 4, 2025
Good to put in a link to ACT

Just adding a link as it wasn't clear to someone new to this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants