Skip to content

chore: update or replace pinned .x deps#4180

Merged
straker merged 6 commits intodevelopfrom
deps-10-2023
Oct 12, 2023
Merged

chore: update or replace pinned .x deps#4180
straker merged 6 commits intodevelopfrom
deps-10-2023

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Oct 11, 2023 •
edited
Loading

This is in preparation for #4179 and only pinning to non-esm dependencies we still absolutely need. This pr:

  • replaces globby with glob
  • updates html-entities to latest
  • removes markdown-table

@straker straker requested a review from a team as a code owner October 11, 2023 23:25
@straker straker mentioned this pull request Oct 11, 2023
Merged
@dbjorge
Copy link
Copy Markdown
Contributor

dbjorge commented Oct 11, 2023

Did you verify that updating esbuild doesn't re-introduce #3771 ?

dbjorge
dbjorge previously requested changes Oct 11, 2023
View reviewed changes
@straker
Copy link
Copy Markdown
Contributor Author

straker commented Oct 11, 2023

Did you verify that updating esbuild doesn't re-introduce #3771

Yep. Using latest installs of everything and using npm link to symlink axe-core into the repo and it builds without issues.

successful build output of running `npm run serve` in a vue/vite repo with axe-core dependency

Here's my package files:

Root dir:

{
  "dependencies": {
    "@vue/cli": "^5.0.8"
  }
}

Project repo after running the cli to build a project

{
  "name": "bug-repro",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "serve": "vue-cli-service serve",
    "build": "vue-cli-service build",
    "lint": "vue-cli-service lint"
  },
  "dependencies": {
    "core-js": "^3.8.3",
    "vue": "^3.2.13"
  },
  "devDependencies": {
    "@babel/core": "^7.12.16",
    "@babel/eslint-parser": "^7.12.16",
    "@vitejs/plugin-vue": "^4.4.0",
    "@vue/cli-plugin-babel": "~5.0.0",
    "@vue/cli-plugin-eslint": "~5.0.0",
    "@vue/cli-service": "~5.0.0",
    "axe-core": "^4.8.2",
    "eslint": "^7.32.0",
    "eslint-plugin-vue": "^8.0.3",
    "vue-axe": "^3.1.2"
  },
  "eslintConfig": {
    "root": true,
    "env": {
      "node": true
    },
    "extends": [
      "plugin:vue/vue3-essential",
      "eslint:recommended"
    ],
    "parserOptions": {
      "parser": "@babel/eslint-parser"
    },
    "rules": {}
  },
  "browserslist": [
    "> 1%",
    "last 2 versions",
    "not dead",
    "not ie 11"
  ]
}

@straker
Copy link
Copy Markdown
Contributor Author

straker commented Oct 12, 2023

Oh, nevermind. I had linked axe-core but then it unlinked before I ran the test. Problem is still there

@straker
Revert "chore: update deps"
160f070 
This reverts commit a86d25d.
@straker straker merged commit 513b091 into develop Oct 12, 2023
@straker straker deleted the deps-10-2023 branch October 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbjorge dbjorge dbjorge approved these changes

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@straker @dbjorge @WilcoFiers