Conversation
dbjorge
previously requested changes
Oct 11, 2023
Contributor
Author
|
Created #4180 to update or replace all the pins |
WilcoFiers
approved these changes
Oct 12, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM. Left one suggestions
| # Prevent the prettierignore change from being committed. | ||
| - run: git checkout .prettierignore | ||
| - uses: stefanzweifel/git-auto-commit-action@v4 | ||
| - uses: stefanzweifel/git-auto-commit-action@8756aa072ef5b4a080af5dc8fef36c5d586e521d # tag=v5 |
Contributor
There was a problem hiding this comment.
I assume you did a security review on these. Is it worth sticking a comment in here to document that?
Contributor
There was a problem hiding this comment.
Checking in a tag + pinned SHA like this is exactly comparable to checking in a version range + lockfile for an npm dependency - why require comments here but not there?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dependabot configuration for automatically updating dependencies for NPM and GitHub Actions. While I was updating the actions for sha pinning, I also updated to not use
actions/cachefor npm cache and instead useactions/setup-nodeas is recommended, and updated the actions to run on node 20.