docs: make quotes usage consistent in messages of rules and checks#4144
Merged
WilcoFiers merged 2 commits intodequelabs:developfrom Sep 5, 2023
Merged
Conversation
Contributor
ma10
commented
Sep 1, 2023
- Replace name='value' with name="value"
- don't enclose name=value in single quotes
* Replace name='value' with name=\"value\" * don't enclose name=value in single quotes
WilcoFiers
approved these changes
Sep 5, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Great stuff! Thank you for the contribution @ma10
Contributor
|
Reviewed for security. |
ma10
added a commit
to ma10/axe-core
that referenced
this pull request
Sep 8, 2023
Reflect the changes in PR dequelabs#4144 (quote usage) Update checks/target-offset to be in line with the current messages. Update rules/aria-allowed-attr to be in-line with the current messages.
straker
added a commit
that referenced
this pull request
Sep 11, 2023
* chore(i18n): update Japanese translation Reflect the changes in PR #4144 (quote usage) Update checks/target-offset to be in line with the current messages. Update rules/aria-allowed-attr to be in-line with the current messages. * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> --------- Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.