Skip to content

Align impact levels with Deque Way#409

Merged
dylanb merged 1 commit intodevelopfrom
fix/dq-way-impact
Jul 12, 2017
Merged

Align impact levels with Deque Way#409
dylanb merged 1 commit intodevelopfrom
fix/dq-way-impact

Conversation

@WilcoFiers
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers commented Jul 6, 2017

Thanks to the work of Matt Isner, I had a nice list to work from. I’ve double checked that for each impact I changed, it only changes the impact level of the rules I wanted to change. The changes are as follow:

Rule Impact from Impact to
accesskeys critical serious
blink minor serious
marquee minor serious
document-title moderate serious
duplicate-id critical moderate
heading-order minor moderate
link-in-text-b critical serious
listitem critical serious
p-as-heading critical serious
scope-attr-val critical, serious critical, moderate
server-side-ima minor critical
skip-link critical moderate
table-duplicate-name moderate minor
table-fake-caption critical serious
th-has-data-cells critical serious
video-description serious critical
bypass critical serious
empty-heading moderate minor
frame-title critical serious
link-name critical serious
object-alt critical serious

@WilcoFiers
Copy link
Copy Markdown
Contributor Author

We might want to hold off on releasing this until aXe 3.0, as it might be a impactful change for some users.

@marcysutton
Copy link
Copy Markdown
Contributor

How did you double-check the impact for rules vs. checks (that are potentially reused in multiple rules)? I'm wondering if we should write any tests around that to make it less of a manual process.

@WilcoFiers
Copy link
Copy Markdown
Contributor Author

@marcysutton frustratingly enough, just a regular file search, look at all the rules that have that particular check, then look at the other checks they have and make sure one of those has the impact level we want. With 'any', it'll always take the highest impact level, so just one of them has to have 'critical' for example. for the rule to turn out with critical.

@dylanb
Copy link
Copy Markdown
Contributor

dylanb commented Jul 7, 2017

color-contrast went from serious to serious?

I don't see a huge reason to delay this release...perhaps users could comment here if they think it will be disruptive

@WilcoFiers
Copy link
Copy Markdown
Contributor Author

The color-contrast hasn't changed. That one had been updated a few weeks back. I think we can merge this.

@dylanb dylanb merged commit 5324040 into develop Jul 12, 2017
@marcysutton marcysutton deleted the fix/dq-way-impact branch August 15, 2017 19:24
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants