Conversation
WilcoFiers
previously requested changes
Jan 12, 2023
| assert.isTrue(focusDisabled(vNode)); | ||
| }); | ||
|
|
||
| it('returns false if element is inside a legend inside a disabled fieldset', () => { |
Contributor
There was a problem hiding this comment.
😮 How did you find that one??
| assert.isFalse(isNativelyFocusable(el)); | ||
| }); | ||
|
|
||
| it('should return false for a div with a tabindex with spaces', () => { |
Contributor
Author
There was a problem hiding this comment.
¯\(ツ)/¯. Seems the tabindex is set to 0 ?
WilcoFiers
previously requested changes
Jan 16, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Did you forget to push or something?
WilcoFiers
approved these changes
Jan 16, 2023
straker
added a commit
that referenced
this pull request
Jan 23, 2023
* tests: refactor is-focusable tests * negative tabindex * Update test/commons/dom/is-natively-focusable.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was starting to work on allowing the
inertattribute to determine when things were focusable and noticed that there were no test files foris-natively-focusable,inserted-into-focus-orderandfocus-disabled. Turns out most of the tests were all part of theis-focusabletest code so split them out into their own files.focus-disableddidn't have any dedicated tests even insideis-focusable, so had to add a bunch. This also meant that I needed to addfocus-disabledto thecommonsobject so I could access it like everything else.Changes made:
dom.isNativelyFocusableanddom.insertedIntoFocusOrderdescribes into their own files (with updated es6 syntax for arrow functions andconstinstead ofvar)focus-disabledtests (all new). Will need to verify that they cover all casesfocus-disabledto thecommonsfunctions