fix(color-contrast): correctly compute color contrast of <slot> elements#3847
Merged
WilcoFiers merged 2 commits intodevelopfrom Jan 6, 2023
Merged
fix(color-contrast): correctly compute color contrast of <slot> elements#3847WilcoFiers merged 2 commits intodevelopfrom
WilcoFiers merged 2 commits intodevelopfrom
Conversation
straker
commented
Jan 5, 2023
| ); | ||
|
|
||
| (shadowSupported ? it : xit)('handles <slot> elements', () => { | ||
| fixture.innerHTML = |
Contributor
Author
There was a problem hiding this comment.
I couldn't use shadowCheckSetup because I needed the final node to be the paragraph, but trying to have the paragraph in the first parameter had the code add the shadow dom to it rather than the container element.
straker
commented
Jan 5, 2023
| const shadowContainer = shadow.querySelector('#shadowContainer'); | ||
| axe.testUtils.flatTreeSetup(fixture); | ||
|
|
||
| const target = fixture.querySelector('#target'); |
Contributor
Author
There was a problem hiding this comment.
Couldn't use axe.utils.querySelector since the element is in the shadow dom in the virtual tree, so would need to select the shadow element and query selector from there.
WilcoFiers
previously requested changes
Jan 6, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
I'm not sure I fully understand the problem. Would like to get on a call to discuss.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Jan 6, 2023
Closed
straker
added a commit
that referenced
this pull request
Jan 23, 2023
…nts (#3847) * fix(color-contrast): correctly compute color contrast of <slot> elements * Update lib/commons/dom/create-grid.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3329