Merged
Conversation
stephenmathieson
previously approved these changes
Jan 4, 2023
| command: | | ||
| if [ -d "node_modules" ]; then | ||
| echo "node_modules exist" | ||
| circleci step halt |
Member
There was a problem hiding this comment.
Fancy! I didn't know this was a thing.
WilcoFiers
previously requested changes
Jan 5, 2023
WilcoFiers
approved these changes
Jan 6, 2023
straker
added a commit
that referenced
this pull request
Jan 23, 2023
* ci: cache axe.js build * use correct brackets * skip install if cache exists * test skip * finalize * add axe.min.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking through the circle ci script I saw a few things we could improve to speed up the process or just clean up the file a bit. In total, this shaved off about 3.5 minutes from the build.
Here's the changes:
npm ciand saving the cache.npm ciremovesnode_modulesbefore installing, so restoring the cache before installing isn't helpful. You can see this working here and when the cache doesn't exist herereleaseas it depended onholdwhich already depended on everything elsenext_releasestep depend on all the jobs instead of just someI'm open to suggestions and/or changes if we don't think we should cache the axe.js build.