Merged
Conversation
chore: merge master
…have focusable children (#3056) * fieldset that's hidden and disabled should mean input inside is not focusable * only return true if elements are in same shadow tree * use break * fix performance issue * change target to fieldset element * do caching better * fix return value * more caching
* add test * stop mutating * does not mutate inputs * cleanup * clone another way * remove temp variable * don't deep clone dom nodes * remove console log * add comment Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> * check if window exists Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * clone all at once at first * also allow instanceof HTMLCollection for ie11 Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Stephen Mathieson <me@stephenmathieson.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…s if group is present (#3084)
…true (#3089) * fix(aria-required-attr): only require aria-controls if aria-expanded=true * fix tests * fix for modified standads
…3088) * fix(run,finishRun): don't mutate options, set default reporter to v1 * normalize options in runOnly * fix test
…3097) * fix(color-contrast): check for size before ignoring pseudo elements * chore(eslint): disable no-use-bef-re-define * chore: tweak tests for IE * chore: address IE11 problem * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * chore: tweak * Update lib/checks/color/color-contrast-evaluate.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Contributor
|
Reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.