fix(run,finishRun): don't mutate options, set default reporter to v1#3088
Merged
fix(run,finishRun): don't mutate options, set default reporter to v1#3088
Conversation
Contributor
Author
|
I'm not sure what we should do at this point. The test is failing because we need to mutate the The only thing I can think of is that we don't use the modified options object in the reporter but instead try to use the original options object the user uses for const runResults = await axe.run({ runOnly: 'region' });
console.log(runResults.toolOptions.runOnly) // { type: 'rule', values: ['region'] }
const partialResults = await axe.runPartial({ runOnly: 'region' });
const partialRunResults = await axe.finishRun({ runOnly: 'region' });
console.log(partialRunResults.toolOptions.runOnly) // 'region' |
WilcoFiers
previously requested changes
Jul 21, 2021
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM, but can you also get rid of the use of clone in testUtils.runPartialRecursive. We're not going to need it there anymore now that we have this in.
WilcoFiers
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where not passing an
optionsobject toaxe.finishRunwould result in axe not using thev1reporter even though the v1 reporter is the default for a axe.run. This caused the results of theaxe.finishRunto not includefailureSummary.The better question would be why we set the v2 reporter as default when axe.run uses the v1 by default.