Conversation
stephenmathieson
previously requested changes
Jul 17, 2019
stephenmathieson
left a comment
Member
There was a problem hiding this comment.
Our fork needs to be published to npm. Using GitHub this way will prevent us from having predictable/reproducible builds.
stephenmathieson
approved these changes
Jul 17, 2019
stephenmathieson
left a comment
Member
There was a problem hiding this comment.
This is amazing.
I might call this a "feat" or "fix" to ensure it shows up in our changelog tho.
WilcoFiers
pushed a commit
that referenced
this pull request
Jul 22, 2019
* chore: use deque fork of doT.js * use npm package
kevindew
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Dec 30, 2022
This use of unsafe_eval was required when we were using axe-core < 3.31 [1]. We are now using version 4.6.1 so can remove this code. [1]: dequelabs/axe-core#1707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows running axe-core's critical path
axe.run()in strict CSPs by using deque's fork of doT.js. It will not allow axe to run if the user has configured translations throughaxe.configureor if using custom rules.You can verify that our fork of doT.js no longer causes a CSP violation with this codepen https://codepen.io/straker/pen/GVKwde
Linked issue: #1175
Reviewer checks
Required fields, to be filled out by PR reviewer(s)