fix(scrollable-region-focusable): skip native controls#3862
Merged
WilcoFiers merged 1 commit intodevelopfrom Jan 20, 2023
Merged
fix(scrollable-region-focusable): skip native controls#3862WilcoFiers merged 1 commit intodevelopfrom
WilcoFiers merged 1 commit intodevelopfrom
Conversation
straker
approved these changes
Jan 19, 2023
Closed
straker
pushed a commit
that referenced
this pull request
Jan 23, 2023
Merged
This was referenced Jul 25, 2023
codeofdusk
added a commit
to microsoft/accessibility-insights-web
that referenced
this pull request
Aug 1, 2023
…description, and promote scrollable-region-focusable (#6849) This commit updates axe-core to its latest version, 4.7.2, from 4.6.3. It also bumps the accessibility-insights-report package version. As part of the axe-core update: * The `aria-roledescription` rule has been deprecated (dequelabs/axe-core#3649). * `scrollable-region-focusable` axe-core rule failures have been promoted from "needs review" to "serious" (manually removed from explicit "needs review" but included automatically by axe-core), see dequelabs/axe-core#3862 and dequelabs/axe-core#3939. * `falsePositiveRemoval` introduced in ed75fda has been removed as the corresponding dequelabs/axe-core#3850 has been resolved. Part of Feature 2086120 (internal access required to view).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule isn't intended to test native controls. I'm honestly surprised that
getScroll()doesn't causeselectandtextareato be skipped like it does forinputelements with lengthy texts. I suppose browsers did that to give the things their scrollbar, whichinputnever gets.Closes #3692, closes #3691, closes #3701