Skip to content

fix(scrollable-region-focusable): report inapplicable if scrollable regions are disabled#3701

Closed
Zidious wants to merge 9 commits intodevelopfrom
fix/scrollable-region-focusable
Closed

fix(scrollable-region-focusable): report inapplicable if scrollable regions are disabled#3701
Zidious wants to merge 9 commits intodevelopfrom
fix/scrollable-region-focusable

Conversation

@Zidious
Copy link
Copy Markdown
Contributor

@Zidious Zidious commented Oct 6, 2022

This PR checks if the scrollable content has the disabled attribute, if so we can ignore it as it is not focusable by the keyboard

Closes issue: #3692, #3691

@Zidious Zidious marked this pull request as ready for review October 6, 2022 03:52
@Zidious Zidious requested a review from a team as a code owner October 6, 2022 03:52
@Zidious
Copy link
Copy Markdown
Contributor Author

Zidious commented Oct 7, 2022

After looking into this for firefox CI failure.

With the following snippet:

<textarea id="pass8" name="textarea" aria-label="test">
  hazaar
  hazaar
  hazaar
</textarea>

Within scrollable-region-focusable we call getScroll() which calls this function isScrollable().

Here we check the scrollableX and scrollableY values have the scroll or overflow prop;

With Chrome we get:

{overflowProp: 'auto'}

Interestingly, with Firefox we get (unless we explicitly add style: "overflow: auto") :

{ overflowProp: "visible" }

I was not sure if adding visible to the overflowProp include check had possible negative side effects - possibly requires more discussion 👀

@Zidious
Copy link
Copy Markdown
Contributor Author

Zidious commented Dec 20, 2022

\cc @WilcoFiers / @straker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants