fix(scrollable-region-focusable): report inapplicable if scrollable regions are disabled#3701
Closed
fix(scrollable-region-focusable): report inapplicable if scrollable regions are disabled#3701
Conversation
straker
requested changes
Oct 6, 2022
test/integration/rules/scrollable-region-focusable/scrollable-region-focusable.html
Show resolved
Hide resolved
Contributor
Author
|
After looking into this for firefox CI failure. With the following snippet: <textarea id="pass8" name="textarea" aria-label="test">
hazaar
hazaar
hazaar
</textarea>Within Here we check the With Chrome we get: Interestingly, with Firefox we get (unless we explicitly add I was not sure if adding |
Contributor
Author
|
\cc @WilcoFiers / @straker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks if the scrollable content has the
disabledattribute, if so we can ignore it as it is not focusable by the keyboardCloses issue: #3692, #3691