Skip to content

Issue #1525 Add support for Symfony 8.x#1526

Merged
gennadigennadigennadi merged 17 commits into
deptrac:4.xfrom
makomweb:4.x
Jan 22, 2026
Merged

Issue #1525 Add support for Symfony 8.x#1526
gennadigennadigennadi merged 17 commits into
deptrac:4.xfrom
makomweb:4.x

Conversation

@makomweb

Copy link
Copy Markdown
Contributor

No description provided.

@makomweb makomweb mentioned this pull request Dec 16, 2025
@makomweb

Copy link
Copy Markdown
Contributor Author

Also noticed this one: 94ee640

@xabbuh

xabbuh commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

The failures from #1515 are relevant.

@makomweb

makomweb commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

Turns out this required some more changes than expected. Much of it could be implemented using GH copilot.
Let me know if there is anything I can adjust. The summary file contains a more detailed explanation.

@makomweb

makomweb commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@xabbuh Can you have a look and point me into the right direction?

Comment thread deptrac.baseline.yaml
Comment thread Makefile Outdated
Comment thread src/Contract/Ast/AstMap/AstInherit.php
Comment thread src/Contract/OutputFormatter/OutputFormatterNames.php Outdated
Comment thread src/Supportive/Console/Command/DebugUnusedRunner.php
Comment thread src/Supportive/DependencyInjection/DeptracPhpConfigLoader.php
Comment thread src/Contract/Config/ConfigBuilderInterface.php Outdated
Comment thread src/Supportive/DependencyInjection/DeptracPhpConfigLoader.php
@gennadigennadigennadi

Copy link
Copy Markdown
Collaborator

All in all this approach seems to solve our problem, thank you very much @makomweb.

But before I would merge it, this MR needs a cleanup.
Please revert every change that is not required for implementing the DeptracPhpConfigLoader.

makomweb added a commit to makomweb/deptrac that referenced this pull request Jan 12, 2026
@makomweb makomweb mentioned this pull request Jan 12, 2026
@makomweb

Copy link
Copy Markdown
Contributor Author

@gennadigennadigennadi I kindly ask if you can give some more advice to bring this one forward 😄

@patrickkusebauch

Copy link
Copy Markdown
Collaborator

I am not going to review this one, as my expertise in Symfony is rather poor. I am more of the AST expert for Deptrac.

@gennadigennadigennadi

Copy link
Copy Markdown
Collaborator

I'll try to do a final review next week.

@gennadigennadigennadi gennadigennadigennadi merged commit c534666 into deptrac:4.x Jan 22, 2026
17 checks passed
@gennadigennadigennadi

Copy link
Copy Markdown
Collaborator

@makomweb thx for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants