Update phpstan/phpdoc-parser#1488
Conversation
|
@patrickkusebauch Any chance we can move on with this PR? There is currently no PHP 8.4 support and because of that we get a lot of parsing errors when running deptrac 😅 |
|
I am not a maintainer, only an avid contributor. So I cannot help with this PR beyond what I have already done, that is giving it a review. I do not have the privileges to merge code or release new versions. |
Okay thanks 😃 let's ping someone else then 😉 |
|
@alleknalle could you help me out with why you think there is no php8.4 support? With the php-parser v5 and the deptrac v4 release we have added support for php8.4 |
|
Btw: why the php 8.2 requirement? |
|
@gennadigennadigennadi I will let you know all the details tomorrow. |
|
@gennadigennadigennadi okay, I've checked what happens in my project and why I don't have any PHP 8.4 support. Deptrac 3.0.0 only requires PHP 8.1 and ext-json in Deptrac 4.0.0 has multiple dependencies in So I would like to update Deptrac to Symfony 7 and phpstan/phpdoc-parser. I have started the whole thing from the 4.* branch again and these are my findings for the PR's that I've created:
So I think this current PR can be closed and we can follow up on the PR's mentioned above. |
|
@gennadigennadigennadi I've double checked for Symfony 7 support, but we can also go for #1495 without dropping support for PHP 8.1 😃 |
Depends on #1487