Skip to content

Update phpstan/phpdoc-parser#1488

Closed
alleknalle wants to merge 2 commits into
deptrac:4.xfrom
alleknalle:update-phpstan-phpdoc-parser
Closed

Update phpstan/phpdoc-parser#1488
alleknalle wants to merge 2 commits into
deptrac:4.xfrom
alleknalle:update-phpstan-phpdoc-parser

Conversation

@alleknalle

@alleknalle alleknalle commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Depends on #1487

@alleknalle alleknalle marked this pull request as ready for review August 4, 2025 08:53
@alleknalle

Copy link
Copy Markdown
Contributor Author

@patrickkusebauch Any chance we can move on with this PR? There is currently no PHP 8.4 support and because of that we get a lot of parsing errors when running deptrac 😅

@patrickkusebauch

Copy link
Copy Markdown
Collaborator

I am not a maintainer, only an avid contributor. So I cannot help with this PR beyond what I have already done, that is giving it a review. I do not have the privileges to merge code or release new versions.

@alleknalle

Copy link
Copy Markdown
Contributor Author

I am not a maintainer, only an avid contributor. So I cannot help with this PR beyond what I have already done, that is giving it a review. I do not have the privileges to merge code or release new versions.

Okay thanks 😃 let's ping someone else then 😉
Maybe @gennadigennadigennadi or @dbrumann can check this out?

@gennadigennadigennadi

Copy link
Copy Markdown
Collaborator

@alleknalle could you help me out with why you think there is no php8.4 support? With the php-parser v5 and the deptrac v4 release we have added support for php8.4

@gennadigennadigennadi

Copy link
Copy Markdown
Collaborator

Btw: why the php 8.2 requirement?

@alleknalle

alleknalle commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@gennadigennadigennadi
I will take a look at it again tomorrow, but I remember I got issues with updating the phpstan/phpdoc-parser on php 8.1.

I will let you know all the details tomorrow.

@alleknalle

alleknalle commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

@gennadigennadigennadi okay, I've checked what happens in my project and why I don't have any PHP 8.4 support.

Deptrac 3.0.0 only requires PHP 8.1 and ext-json in composer.json, see https://github.com/deptrac/deptrac/blob/3.0.0/composer.json. Since there are no other dependencies for Composer, I can use this version in my project.

Deptrac 4.0.0 has multiple dependencies in composer.json, see https://github.com/deptrac/deptrac/blob/4.x/composer.json.
I can't upgrade to Deptrac 4.0.0, because I'm using Symfony 7 and phpstan/phpdoc-parser 2.*

So I would like to update Deptrac to Symfony 7 and phpstan/phpdoc-parser.

I have started the whole thing from the 4.* branch again and these are my findings for the PR's that I've created:

  1. PR Fix phpunit deprecations #1490 is an easy fix for phpunit deprecations and I think this can be merged
  2. Looks like PHP 8.4 is indeed not needed for phpstan/phpddoc-parser 2, so I've created a new PR for this: Use phpstan/phpdoc-parser v2 #1494
  3. For Symfony 7 PHP 8.2 is needed, so Add support for symfony 7 #1489 is complete for Symfony 7, which depends on PR Drop PHP 8.1 support #1487 and Add PHP 8.4 support #1491.

So I think this current PR can be closed and we can follow up on the PR's mentioned above.

@alleknalle

Copy link
Copy Markdown
Contributor Author

@gennadigennadigennadi I've double checked for Symfony 7 support, but we can also go for #1495 without dropping support for PHP 8.1 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants