Add support for Symfony 7 without dropping PHP8.1#1495
Merged
gennadigennadigennadi merged 1 commit intoAug 25, 2025
Conversation
This was referenced Aug 15, 2025
Collaborator
|
Could you also bump the symphony/... dependencies v6 to ^6.4, please. Could you instead of implementing the functions use the attribute? |
eada7ce to
8ff9da3
Compare
8ff9da3 to
fb0cecd
Compare
Contributor
Author
done 😃 |
Closed
|
@gennadigennadigennadi or @dbrumann when can we expect a release to that this code is actually usable? |
|
Building a release with this merged PR fixes 3 issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative PR for #1489 without dropping PHP 8.1 support
Looks like this does not use Symfony 7 in the pipeline because of
composer.lock.Shouldn't we remove
composer.lockfrom the repo? It's only used while working on the project, but now we are always working with fixed versions, see https://getcomposer.org/doc/02-libraries.md#lock-file.This means we can't test version restrictions like
^6.0|^7.0, because during all pipeline checks the same version is used.