Merged
Conversation
Replace SVG with version that uses light text in dark mode Use picture element with media queries
Merged
jeffwidman
added a commit
to dependabot/fetch-metadata
that referenced
this pull request
Sep 18, 2022
The current logo is broken. So replace with the new one. Copied from dependabot/dependabot-core#5298. 🎩 💁♂️ to @mattt 's attention to detail including supporting both light and dark themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logo used in the current README hardcodes the
fillvalue for its text to#24292E. This causes the text to have a contrast ratio of 1.02:1 against its background color (#22272E) when viewed in dark mode.This PR updates the README to replace the
<img>element with a<picture>containing image sources with light and dark media queries. 1The embedded SVGs are uploaded directly to GitHub, whereas the previous was hot-linked from our AWS bucket.
Here's how the README looks after applying these changes:
Footnotes
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to ↩