Skip to content

feat: add io/buffer and io/util module#808

Merged
lucacasonato merged 1 commit into
mainfrom
io_buffer
Mar 22, 2021
Merged

feat: add io/buffer and io/util module#808
lucacasonato merged 1 commit into
mainfrom
io_buffer

Conversation

@lucacasonato

Copy link
Copy Markdown
Contributor

This moves the Deno.Buffer and Deno.readAll / Deno.readAllSync /
Deno.writeAll / Deno.writeAllSync implementations to std, so we can
deprecate them in Deno 1.9, and remove them in Deno 2.0.

lucacasonato added a commit to lucacasonato/deno that referenced this pull request Mar 15, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
lucacasonato added a commit to lucacasonato/deno that referenced this pull request Mar 15, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
@nayeemrmn

nayeemrmn commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

The exports of io/buffer.ts and io/util.ts can all go in io/bufio.ts (which I prefer was named io/buffer.ts, but breaking). They all provide some kind of buffering/unbuffering for Deno IO. Not sure what io/buffer vs io/bufio would be.

@lucacasonato

Copy link
Copy Markdown
Contributor Author

I think that makes sense. We can combine all three into io/buffer.ts. I don't think the breaking change matters as std is still pre 1.0.

lucacasonato added a commit to lucacasonato/deno that referenced this pull request Mar 15, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.

@ry ry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

This moves the `Deno.Buffer` and `Deno.readAll` / `Deno.readAllSync` /
`Deno.writeAll` / `Deno.writeAllSync` implementations to std, so we can
deprecate them in Deno 1.9, and remove them in Deno 2.0.
@lucacasonato lucacasonato merged commit be89f5a into main Mar 22, 2021
@lucacasonato lucacasonato deleted the io_buffer branch March 22, 2021 21:45
lucacasonato added a commit to lucacasonato/deno that referenced this pull request Apr 1, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
lucacasonato added a commit to lucacasonato/deno that referenced this pull request Apr 5, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
lucacasonato added a commit to lucacasonato/deno that referenced this pull request Apr 5, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
lucacasonato added a commit to denoland/deno that referenced this pull request Apr 5, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Apr 6, 2021
This commit marks the `Deno.Buffer` / `Deno.readAll` /
`Deno.readAllSync` / `Deno.writeAll` / `Deno.writeAllSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/buffer and std/io/util:
denoland/std#808.

This additionallty removes all internal dependance on Deno.Buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants