Skip to content

chore(http/file_server): add module documentation#3368

Merged
kt3k merged 5 commits intodenoland:mainfrom
ayame113:file_server_document
May 10, 2023
Merged

chore(http/file_server): add module documentation#3368
kt3k merged 5 commits intodenoland:mainfrom
ayame113:file_server_document

Conversation

@ayame113
Copy link
Contributor

@ayame113 ayame113 commented May 6, 2023

part of #3361

@ayame113 ayame113 requested a review from kt3k as a code owner May 6, 2023 19:57
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayame113
Copy link
Contributor Author

ayame113 commented May 9, 2023

Unfortunately I think I ran into a bug in the deno doc. denoland/deno_doc#336
The file_server.ts has a shebang so the @module JSDoc tag can't be displayed properly.

@lino-levan
Copy link
Contributor

Please deno fmt

@ayame113
Copy link
Contributor Author

ayame113 commented May 9, 2023

@lino-levan CI failure is related to #3373

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 28d2dd2 into denoland:main May 10, 2023
@ayame113 ayame113 deleted the file_server_document branch May 10, 2023 05:34
mxdvl pushed a commit to mxdvl/deno_std that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants