chore(http/file_server): remove unnecessary Date header generation#3364
Merged
kt3k merged 2 commits intodenoland:mainfrom May 6, 2023
Merged
chore(http/file_server): remove unnecessary Date header generation#3364kt3k merged 2 commits intodenoland:mainfrom
kt3k merged 2 commits intodenoland:mainfrom
Conversation
Contributor
Is there anywhere that references this fact? |
Member
The Date header should be set by hyper as it's mandatory by HTTP spec. https://www.rfc-editor.org/rfc/rfc9110.html#section-6.6.1-6
(I couldn't find exact code, but I found this issue hyperium/hyper#2998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #3361
As far as I know, when this code was first introduced we had to manually set the Date header. The CLI now automatically sets the Date header, so we no longer need to manually set the Date header.
There is one more place to set the Date header (link), but I left it that way because it seemed meaningful.
Also renamed
setBaseHeadertocreateBaseHeaderas I thought it would be more appropriate.I apologize for submitting the PR all at once. Feel free to close these PRs if you don't think you need them.