fix(http/file_server): Redirect non-canonical URL to canonical URL#3362
Merged
kt3k merged 2 commits intodenoland:mainfrom May 6, 2023
Merged
fix(http/file_server): Redirect non-canonical URL to canonical URL#3362kt3k merged 2 commits intodenoland:mainfrom
kt3k merged 2 commits intodenoland:mainfrom
Conversation
kt3k
approved these changes
May 6, 2023
Member
kt3k
left a comment
There was a problem hiding this comment.
New redirect cases make sense to me. Also this looks nice clean up! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #3361
This PR changes the
serveDir()'s behavior so that URLs are canonicalized.The current behavior and the behavior after the change are as follows.
/path/to/directory🟢200 OK🟡301redirect to/path/to/directory//path/////to/////directory///////🟢200 OK🟡301redirect to/path/to/directory//path/////to/////file.txt🟢200 OK🟡301redirect to/path/to/file.txt/path/to/file.txt/🔴500 Internal Server Error🟡301redirect to/path/to/file.txt/path/////to/////file.txt/🔴500 Internal Server Error🟡301redirect to/path/to/file.txt/path/////to/////file.txt/////🔴500 Internal Server Error🟡301redirect to/path/to/file.txtAlso
serveDir()currently has 7 nestings (function-try-if-if-try-if-if). I cut this part out into a separate function.