Skip to content

feat: add "lts" version option#97

Merged
dsherret merged 7 commits intodenoland:mainfrom
sebdanielsson:add-lts-version-option
May 12, 2025
Merged

feat: add "lts" version option#97
dsherret merged 7 commits intodenoland:mainfrom
sebdanielsson:add-lts-version-option

Conversation

@sebdanielsson
Copy link
Copy Markdown
Contributor

@sebdanielsson sebdanielsson commented May 1, 2025

Implement the "lts" version option for Deno setup.

  • action.yml

    • Add "lts" as a valid option for the deno-version input.
  • README.md

    • Add usage example for the "lts" version option.
  • src/version.mjs

    • Add logic to handle the "lts" version option in parseVersionRange function.
    • Add resolveLTS function to fetch the latest lts version.
    • Update resolveVersion function to handle "lts" version option.
  • .github/workflows/test.yml

    • Add a test for the "lts" version option.

For more details, open the Copilot Workspace session.

Implement the "lts" version option for Deno setup.

* **action.yml**
  - Add "lts" as a valid option for the `deno-version` input.

* **README.md**
  - Add usage example for the "lts" version option.

* **src/version.mjs**
  - Add logic to handle the "lts" version option in `parseVersionRange` function.
  - Add `resolveLTS` function to fetch the latest lts version.
  - Update `resolveVersion` function to handle "lts" version option.

* **.github/workflows/test.yml**
  - Add a test for the "lts" version option.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/denoland/setup-deno?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link
Copy Markdown
Contributor

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret requested a review from Copilot May 12, 2025 15:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the "lts" option to the Deno setup action by extending version parsing and resolution logic, updating configuration files, and adding relevant tests.

  • Update JSDoc typedefs and version range parsing in src/version.mjs
  • Introduce a new resolveLTS function and extend install logic for the "lts" channel
  • Update action description, README example, and tests to include the new option

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/version.mjs Added "lts" support in version parsing and resolution with a new resolveLTS function
src/install.mjs Added a corresponding case for "lts" in installation process
action.yml Updated input description to include "lts" option
README.md Added usage example for the "lts" option
.github/workflows/test.yml Added test case for the "lts" option

@dsherret dsherret changed the title Add LTS version option feat: add "lts" version option May 12, 2025
@dsherret dsherret merged commit a1496dd into denoland:main May 12, 2025
31 checks passed
@dsherret dsherret mentioned this pull request May 15, 2025
crowlKats pushed a commit that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants