chore: update node_test submodule to Node.js 25.8.1#32705
Merged
bartlomieju merged 4 commits intodenoland:mainfrom Mar 15, 2026
Merged
chore: update node_test submodule to Node.js 25.8.1#32705bartlomieju merged 4 commits intodenoland:mainfrom
bartlomieju merged 4 commits intodenoland:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
20 tasks
…le update These tests fail after updating node_test to Node.js 25.8.1. Tracked in denoland#32706 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ffer, uid, gid Use `validateInteger` for timeout, `validateNumber` for maxBuffer, and `validateInt32` for uid/gid to match Node.js error types: - Non-number values throw ERR_INVALID_ARG_TYPE (TypeError) - Out-of-range numbers throw ERR_OUT_OF_RANGE (RangeError) Re-enables test-child-process-spawn-typeerror.js and test-child-process-spawnsync-validation-errors.js. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…est-submodule # Conflicts: # tests/node_compat/config.jsonc
littledivy
approved these changes
Mar 15, 2026
2 tasks
bartlomieju
added a commit
that referenced
this pull request
Mar 18, 2026
## Summary Fixes 8 Node.js compat tests that were failing after the node_test submodule update to Node.js 25.8.1 (#32705). Closes part of #32706. - **`events`**: `listenerCount()` now handles `EventTarget` instances by delegating to `getEventListeners()` - **`worker_threads`**: `cpuUsage()` accepts `NaN`/`null`/`undefined` as "no previous value" (matching Node.js behavior) - **`process`**: add `quic: false` to `process.features` - **`util`**: `parseEnv()` returns a null-prototype object - **`net`**: fix `autoSelectFamilyAttemptTimeout` default from 250 to 500 (matching Node.js) - **`streams`**: pass `readableType`/`type` options through `Duplex.toWeb()` to create byte streams for BYOB readers - **`fs`**: handle `ENOTDIR` in `globSync` `getDirentSync()` instead of throwing --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
tests/node_compat/runner/suitesubmodule from Node.js 24.12.0 (170b25ab) to Node.js 25.8.1 (c5baef08)