refactor: replace dotenvy with deno_dotenv#32263
Merged
Tango992 merged 5 commits intodenoland:mainfrom Feb 23, 2026
Merged
Conversation
Tango992
commented
Feb 22, 2026
| @@ -1 +1 @@ | |||
| ANOTHER_BAR | |||
| ANOTHER_${FOO} | |||
Contributor
Author
There was a problem hiding this comment.
This is the related env file:
deno/tests/specs/eval/env_file/env_file
Lines 1 to 4 in edfbb7d
Currently dotenvy automatically replaces ${FOO} with the value of FOO. Do we wan't to keep this behavior? We don't have this documented on our docs, and popular env parsers like npm:dotenv and Node.js env file implementation don't implement this.
Contributor
There was a problem hiding this comment.
Probably ok if node.js doesn't do this.
dsherret
approved these changes
Feb 23, 2026
| @@ -1 +1 @@ | |||
| ANOTHER_BAR | |||
| ANOTHER_${FOO} | |||
Contributor
There was a problem hiding this comment.
Probably ok if node.js doesn't do this.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Mar 13, 2026
When dotenvy was replaced with deno_dotenv in denoland#32263, the parent directory traversal behavior of `dotenvy::from_filename()` was lost. This caused `--env-file` to no longer find .env files in parent directories when running from a subdirectory. Adds `find_env_file()` which walks up parent directories looking for the named file, restoring the previous behavior. Closes denoland#32683 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #32183 so that we don't need to keep 2 dotenv parsers